[PATCH modesetting] Implement ->driverFunc
Adam Jackson
ajax at redhat.com
Fri Jul 20 15:28:56 PDT 2012
On 7/20/12 3:44 PM, Aaron Plattner wrote:
> On 07/19/2012 03:15 PM, Adam Jackson wrote:
>> +static Bool
>> +ms_driver_func(ScrnInfoPtr scrn, xorgDriverFuncOp op, void *data)
>> +{
>> + xorgHWFlags *flag;
>> +
>> + switch (op) {
>> + case GET_REQUIRED_HW_INTERFACES:
>> + flag = (CARD32 *)data;
>> + (*flag) = 0;
>
> Should this be = 0, or &= ~HW_IO?
It should not be ~HW_IO, since that would set HW_SKIP_CONSOLE, which we
don't want.
It would also set HW_MMIO; somewhat bizarrely that flag has never been
interpreted by the server to mean anything, even in the initial commit.
- ajax
More information about the xorg-devel
mailing list