[PATCH:libXTrap] Fix memset usage.
Thomas Klausner
wiz at NetBSD.org
Fri Jul 20 09:36:23 PDT 2012
On Fri, Jul 20, 2012 at 08:40:26AM +0200, Rémi Cardona wrote:
> Le 18/07/2012 16:47, Thomas Klausner a écrit :
> > - (void)memset(tc,0L,sizeof(tc));
> > + (void)memset(tc,0L,sizeof(*tc));
>
> I'd say you might as well drop the useless cast too.
There are twelve memsets with casts, only one of them has the bug.
So do you want a second patch that removes the casts, or just remove this one cast?
Merging them in one will hide the bug fix in the noise.
Thomas
More information about the xorg-devel
mailing list