[PATCH] Fix two more C99 initialization mistakes using members of same struct

Keith Packard keithp at keithp.com
Sat Jul 14 23:07:11 PDT 2012


Alan Coopersmith <alan.coopersmith at oracle.com> writes:

> Similar to 34cf559bcf99dad, use temporary variables instead of
> referencing members of the struct being initialized in the middle
> of the initialization.

Good find. I'm surprised the compiler isn't catching uninitialized
values here; we're using them before they're set.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120714/5c53183a/attachment.pgp>


More information about the xorg-devel mailing list