[PATCH] Cache xkbcomp output
keithp at keithp.com
Fri Jul 13 08:21:03 PDT 2012
Colin Walters <walters at verbum.org> writes:
> For the GTK+ icon cache, it has a "--force" option to do that, but I
> think it's a fine default to only stat() the toplevel directory and exit
> immediately if the cache timestamp is newer.
For xkb cache files, it is sufficient to simply remove them always
when installing new xkb source files. The server will automatically
regenerate them as needed when run.
> What's relevant particularly here is that the cache file write be
> atomic; I'm not seeing in your patch the code to write it, but hopefully
> it is atomic.
The cache file is generated within the server; right now (as always),
the file is written by xkbcomp and read by the X server. If that
operation fails, then the X server removes the file. If the system
crashes while compiling the keymap, then the (potentially damaged) file
will be detected when the X server tries to load it, and it will be
removed and regenerated.
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 827 bytes
Desc: not available
More information about the xorg-devel