[PATCH xf86-video-nested 0/3] small commit series with the request for comments
consume.noise at gmail.com
consume.noise at gmail.com
Wed Jul 11 15:23:44 PDT 2012
Hi everyone,
I just spend some more time on the nested driver and prepared 3 patches,
any comments are appreciated - I'm a newbie. The patches are numbered,
but don't depend on each other.
[PATCH xf86-video-nested 1/3] Avoid casts, use union members
* No commit message, just beautification
[PATCH xf86-video-nested 2/3] Fix segmentation fault when no modes
specified
* A "should pull" if it isn't wrong. Well, it fixes the seg fault, so it
can't be that wrong.
[PATCH xf86-video-nested 3/3] Resize client (XSetWMNormalHints()) on
mode switch
* That's the patch I'm realy not sure about, if it's correct:
1. Use the hook AdjustFrame instead of SwitchMode
When specifying the modes in the Display SubSection in _descending_
order (ie "800x600" before "640x480"), everything is fine and SwitchMode
would be called on every mode switch. But, when specifying the modes
in ascending order it won't. That's why I'm doing it from
AdjustFrame.
2. Blank the image with memset? What's a more proper way?
greetings,
Daniel
More information about the xorg-devel
mailing list