[PATCH 02/54] Don't make failure to -nolisten fatal

Michal Suchanek hramrach at gmail.com
Tue Jul 10 05:59:06 PDT 2012

On 10 July 2012 14:34, Daniel Stone <daniel at fooishbar.org> wrote:
> Hi,
> On 10 July 2012 12:43, Michal Suchanek <hramrach at gmail.com> wrote:
>> On 10 July 2012 03:02, Daniel Stone <daniel at fooishbar.org> wrote:
>>> If failing to disable a protocol specified by -nolisten failed, we'd
>>> throw a FatalError and bomb startup entirely.  From poking at xtrans, it
>>> looks like the only way we can get a failure here is because we've
>>> specified a protocol name which doesn't exist, which probably doesn't
>>> constitute a security risk.
>> It kind of is if the protocol you specified has a typo in it.
> A fatal error, though?

Pretty much anything on the command line the X server does not
understand is a fatal error. Consistent, isn't it?

>>> And it makes it possible to start gdm even though you've built with
>>> --disable-tcp-transport.
>> Wouldn't it be better if disabling tcp wotked even in this case?
> TCP is pretty effectively disabled if the server does not even know
> TCP exists, because the support was never compiled in.  Enabling it,
> on the other hand, might prove more of a challenge.

yeah, it just does not know it is disabled and reports an error when
you try to disable it from the command line which leads to the error.



More information about the xorg-devel mailing list