[PATCH 02/54] Don't make failure to -nolisten fatal
Daniel Stone
daniel at fooishbar.org
Mon Jul 9 18:02:46 PDT 2012
If failing to disable a protocol specified by -nolisten failed, we'd
throw a FatalError and bomb startup entirely. From poking at xtrans, it
looks like the only way we can get a failure here is because we've
specified a protocol name which doesn't exist, which probably doesn't
constitute a security risk.
And it makes it possible to start gdm even though you've built with
--disable-tcp-transport.
Signed-off-by: Daniel Stone <daniel at fooishbar.org>
---
os/utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/os/utils.c b/os/utils.c
index 2537934..b00d38b 100644
--- a/os/utils.c
+++ b/os/utils.c
@@ -757,8 +757,8 @@ ProcessCommandLine(int argc, char *argv[])
else if (strcmp(argv[i], "-nolisten") == 0) {
if (++i < argc) {
if (_XSERVTransNoListen(argv[i]))
- FatalError("Failed to disable listen for %s transport",
- argv[i]);
+ ErrorF("Failed to disable listen for %s transport",
+ argv[i]);
}
else
UseMsg();
--
1.7.10.4
More information about the xorg-devel
mailing list