pull request : offload slave

Keith Packard keithp at keithp.com
Fri Jul 6 13:21:07 PDT 2012

Dave Airlie <airlied at gmail.com> writes:

>       dix/xf86: initial offload slave tracking (v1.1)
>       randr: add hooks for offload sink provider protocol

So familiar by now.

Reviewed-by: Keith Packard <keithp at keithp.com>

>       xf86: store scanout pixmap in the xf86 struct as well.
>       xf86: add callback for offloak sink setting support.

Reviewed-by: Keith Packard <keithp at keithp.com>

>       dix/randr: add a hook into screen to replace scanout pixmap

This separates out the CrtcSet from SetScanoutPixmap -- will
that actually work if the size is changing at the same time? Or is this
ABI guaranteed to not set the size? If so, why are there a bunch of size
checks, and why is it bothering to call rrCrtcSet at all?

>       dri2: add initial prime support. (v1.2)

prime_id? Seriously? What happens if you change the offload list while
some client is active?

For cases where a compositing manager is not running, you can simply set
the window to automatic redirect, as is done for windows with weird
visuals today. If someone sets it to manual later, then your automatic
will be overridden, and when that manual redirect goes away, automatic
starts up again. Simple.

Otherwise, this stuff all seems OK to me.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120706/461a6e8d/attachment.pgp>

More information about the xorg-devel mailing list