[PATCH] glx: Fix checking GL version

Ian Romanick idr at freedesktop.org
Fri Jul 6 09:01:33 PDT 2012


On 07/05/2012 05:52 PM, Bartosz Brachaczek wrote:
> Signed-off-by: Bartosz Brachaczek<b.brachaczek at gmail.com>

Which is weird because the piglit test for this case passed.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
> Hi,
> I looked at Ian's patch out of curiosity and spotted this typo.
> Not sure if I am supposed to send a full-blown patch for this, but
> I didn't have a better idea.
>
>   glx/glxdri2.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/glx/glxdri2.c b/glx/glxdri2.c
> index 1e99179..2db12b6 100644
> --- a/glx/glxdri2.c
> +++ b/glx/glxdri2.c
> @@ -481,7 +481,7 @@ dri2_convert_glx_attribs(unsigned num_attribs, const uint32_t *attribs,
>        * don't support OpenGL 3.2 may fail the request for a core profile.
>        */
>       if (*api == __DRI_API_OPENGL_CORE
> -&&  (*major_ver<  3 || (*major_ver<  3&&  *minor_ver<  2))) {
> +&&  (*major_ver<  3 || (*major_ver == 3&&  *minor_ver<  2))) {
>           *api == __DRI_API_OPENGL;
>       }
>



More information about the xorg-devel mailing list