[PATCH xorg-server] Fix xf86EdidModes.c: array subscript is above array bounds

Keith Packard keithp at keithp.com
Fri Jul 6 00:44:47 PDT 2012


Torsten Kaiser <just.for.lkml at googlemail.com> writes:

> My guess would be, that these bits where reserved in the spec and
> should never been set.

These bits come from external sources, and often buggy ones at that. We
should probably just compute the index and skip it if it's out of
range. Sending a mode of all zeros along to the rest of the server is
likely to cause chaos (and divide-by-zero errors).

> The two issues where just located so near each other, that I fixed
> them in one go.

It is nice to have separate patches anyways; one per bug. That can make
back-porting changes easier to manage.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120706/4f0ae017/attachment.pgp>


More information about the xorg-devel mailing list