[v2] [PATCH 1/1] XSELinux: When SELinux is enabled the xserver seg faults

[Richard Haines]

Ok - I'll send an updated XSELinux patch [V3] as that will fix the crash 
plus a separate patch for the dix grab.

I don't know the code that well but there are probably other places that
may need checking.

Richard

--- On Thu, 5/7/12, Peter Hutterer <peter.hutterer at who-t.net> wrote:

> 
> thanks for the update. The second part I'm not quite happy
> yet, I think it's
> the wrong approach. With passive grabs on
> XIAll(Master)Devices, the grab
> will activate on whichever device matches the grab. So if
> you issue such a
> grab and device 2 clicks, you'll get a grab on device 2. If
> device 3 clicks,
> you get a grab on device 3.
> 
> For the SELinux case where some devices may not be permitted
> I think we
> should leave open the possibility that _some_ device in the
> future may be
> permitted. This means always return success from a
> XIAll*Devices passive
> grab request but then check for permissions when the grab
> actually
> activates.
> 
> So the example above, if device 2 is restricted you'll be
> able to register a
> passive grab but it won't trigger for device 2, only for
> device 3.
> This needs some extra code in the dix, CheckPassiveGrab to
> be precise to
> return false for restricted devices.
> 
> Cheers,
>   Peter
> _______________________________________________
> xorg-devel at lists.x.org:
> X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>