[PATCH v2 00/29] Reworking initializion of data sent to clients

Alan Coopersmith alan.coopersmith at oracle.com
Wed Jul 4 15:37:14 PDT 2012


Version 2 of this series reworks the patches as requested by Keith, making
them easier to review & see the changes.   Mostly this was done by removing
the addition of new blocks and instead using either existing blocks or
inline anonymous structs/unions.   A number of other changes are split out
into other patches, either to break out for simpler comparison/review the 
non-initialization changes that had snuck in before or due to finding other
things needing fixing while working on the rework.   (git rebase --interactive
is a miracle worker for sure!)

I've also updated it on the "c99-init" branch of
git://people.freedesktop.org/~alanc/xserver.git
http://cgit.freedesktop.org/~alanc/xserver/log/?h=c99-init

While this all builds for me, I've not even tried to run it yet, since I'm
going off now to spend a little bit of today's holiday away from the computer,
but given the impending 1.13 merge window closure, figured I'd get these out
for review in the meantime.

    -alan-

Alan Coopersmith (28):
  Remove unneccesary casts from WriteToClient calls
  Fix more poorly indented/wrapped comments & code
  Rework reply initialization in ProcGetProperty & NullPropertyReply
  Core events: invert check for permission to copy key states
  ProcQueryKeymap: rework logic around permission to copy key states
  Use temporary variables instead of parts of reply structures
  ProcRRGetScreenInfo: swap configTimestamp as well
  ProcRRListOutputProperties: skip atom walk if the list is empty
  xf86dga2.c & xf86vmode.c: Move REQUEST_SIZE_MATCH checks before using
    stuff
  Use calloc to zero fill buffers being allocated for replies & events
  Use C99 designated initializers in SendErrorToClient
  Use C99 designated initializers in dix Replies
  Use C99 designated initializers in Xext Replies
  Use C99 designated initializers in Xinput Replies
  Use C99 designated initializers in various extension Replies
  Use C99 designated initializers in glx Replies
  Use C99 designated initializers in xkb Replies
  Use C99 designated initializers in randr Replies
  Use C99 designated initializers in dmx Replies
  Use C99 designated initializers in Xephyr Replies
  Use C99 designated initializers in xf86 extension Replies
  Use C99 designated initializers in dix Events
  Use C99 designated initializers in extension Events
  Use C99 designated initializers in dix registry
  Set padding bytes to 0 in WriteToClient
  Initialize padding bits to 0 in ErrorConnMax()
  ephyrGLXQueryServerString: Stop making an unused copy of
    server_string
  Replace padlength tables with inline functions from misc.h

Jaroslav Šmíd (1):
  Bug 51375: Xorg doesn't set status for RRGetOutputInfo

 Xext/bigreq.c                         |   13 +-
 Xext/dpms.c                           |   63 +++---
 Xext/geext.c                          |   18 +-
 Xext/panoramiX.c                      |   92 +++++----
 Xext/panoramiXprocs.c                 |   47 +++--
 Xext/saver.c                          |   51 ++---
 Xext/security.c                       |   40 ++--
 Xext/shape.c                          |   81 ++++----
 Xext/shm.c                            |   75 ++++---
 Xext/sync.c                           |  142 +++++++------
 Xext/xcmisc.c                         |   42 ++--
 Xext/xf86bigfont.c                    |   37 ++--
 Xext/xres.c                           |   87 ++++----
 Xext/xselinux_ext.c                   |   42 ++--
 Xext/xtest.c                          |   28 +--
 Xext/xvdisp.c                         |  186 +++++++++--------
 Xext/xvmain.c                         |   26 +--
 Xext/xvmc.c                           |  124 ++++++-----
 Xi/chgdctl.c                          |   25 ++-
 Xi/exevents.c                         |   13 +-
 Xi/extinit.c                          |    5 +-
 Xi/getbmap.c                          |   16 +-
 Xi/getdctl.c                          |   12 +-
 Xi/getfctl.c                          |   14 +-
 Xi/getfocus.c                         |   12 +-
 Xi/getkmap.c                          |   14 +-
 Xi/getmmap.c                          |   16 +-
 Xi/getprop.c                          |   14 +-
 Xi/getselev.c                         |   16 +-
 Xi/getvers.c                          |   19 +-
 Xi/grabdev.c                          |   12 +-
 Xi/grabdevb.c                         |   15 +-
 Xi/grabdevk.c                         |   15 +-
 Xi/gtmotion.c                         |   20 +-
 Xi/listdev.c                          |   13 +-
 Xi/opendev.c                          |   17 +-
 Xi/queryst.c                          |   16 +-
 Xi/setbmap.c                          |   14 +-
 Xi/setdval.c                          |   14 +-
 Xi/setmmap.c                          |   12 +-
 Xi/setmode.c                          |   12 +-
 Xi/xigetclientpointer.c               |   16 +-
 Xi/xigrabdev.c                        |   14 +-
 Xi/xipassivegrab.c                    |   18 +-
 Xi/xiproperty.c                       |  109 +++++-----
 Xi/xiquerydevice.c                    |   15 +-
 Xi/xiquerypointer.c                   |   21 +-
 Xi/xiqueryversion.c                   |   17 +-
 Xi/xiselectev.c                       |   14 +-
 Xi/xisetdevfocus.c                    |   12 +-
 composite/compext.c                   |   37 ++--
 composite/compwindow.c                |    6 +-
 config/udev.c                         |    3 +-
 damageext/damageext.c                 |   32 +--
 dbe/dbe.c                             |   46 ++---
 dix/colormap.c                        |   40 ++--
 dix/devices.c                         |  154 +++++++-------
 dix/dispatch.c                        |  259 ++++++++++++-----------
 dix/dixfonts.c                        |   26 +--
 dix/enterleave.c                      |   23 ++-
 dix/events.c                          |  175 +++++++++-------
 dix/extension.c                       |   22 +-
 dix/grabs.c                           |    5 +-
 dix/inpututils.c                      |   13 +-
 dix/property.c                        |   76 ++++---
 dix/registry.c                        |    4 +-
 dix/selection.c                       |   19 +-
 dix/swaprep.c                         |   88 ++++----
 dix/swapreq.c                         |    2 +-
 dix/window.c                          |  190 +++++++++--------
 glx/glxcmds.c                         |  137 ++++++------
 glx/glxcmdsswap.c                     |   18 +-
 glx/glxdri2.c                         |    5 +-
 glx/indirect_util.c                   |    8 +-
 glx/single2.c                         |   20 +-
 glx/single2swap.c                     |   18 +-
 glx/unpack.h                          |   12 +-
 hw/dmx/dmx.c                          |  257 +++++++++++++----------
 hw/dmx/glxProxy/glxcmds.c             |  149 +++++++-------
 hw/dmx/glxProxy/glxcmdsswap.c         |   43 ++--
 hw/dmx/glxProxy/glxsingle.c           |   56 ++---
 hw/dmx/glxProxy/glxvendor.c           |   12 +-
 hw/dmx/glxProxy/unpack.h              |   12 +-
 hw/kdrive/ephyr/ephyrdriext.c         |  146 ++++++-------
 hw/kdrive/ephyr/ephyrglxext.c         |   95 +++++----
 hw/kdrive/ephyr/ephyrproxyext.c       |    2 +-
 hw/xfree86/common/xf86DGA.c           |  120 +++++------
 hw/xfree86/dixmods/extmod/xf86dga2.c  |  256 ++++++++++++-----------
 hw/xfree86/dixmods/extmod/xf86vmode.c |  298 ++++++++++++++-------------
 hw/xfree86/dri/xf86dri.c              |  145 ++++++-------
 hw/xfree86/dri2/dri2ext.c             |  127 ++++++------
 hw/xquartz/applewm.c                  |    6 +-
 hw/xquartz/pseudoramiX.c              |   12 +-
 hw/xquartz/xpr/appledri.c             |    8 +-
 hw/xwin/winwindowswm.c                |    4 +-
 include/dix.h                         |    4 +-
 include/misc.h                        |   14 ++
 mi/miexpose.c                         |   13 +-
 os/connection.c                       |    2 +-
 os/io.c                               |   12 +-
 randr/rrcrtc.c                        |  133 ++++++------
 randr/rrdispatch.c                    |   11 +-
 randr/rrmode.c                        |   15 +-
 randr/rroutput.c                      |   81 ++++----
 randr/rrproperty.c                    |   93 +++++----
 randr/rrscreen.c                      |  198 +++++++++---------
 randr/rrxinerama.c                    |   93 +++++----
 record/record.c                       |   49 +++--
 render/render.c                       |   22 +-
 test/input.c                          |   34 ++-
 xfixes/cursor.c                       |   41 ++--
 xfixes/region.c                       |    5 +-
 xfixes/select.c                       |   23 +--
 xfixes/xfixes.c                       |   12 +-
 xkb/xkb.c                             |  366 +++++++++++++++++----------------
 xkb/xkbEvents.c                       |   57 ++---
 116 files changed, 3336 insertions(+), 2894 deletions(-)

-- 
1.7.9.2



More information about the xorg-devel mailing list