[PATCH] glx: Revert part of 9838b703

Ian Romanick idr at freedesktop.org
Tue Jul 3 12:03:46 PDT 2012

On 07/02/2012 06:29 PM, Eric Anholt wrote:
> Ian Romanick<idr at freedesktop.org>  writes:
>> From: Ian Romanick<ian.d.romanick at intel.com>
>> The server does not want GL extension prototypes.  It never links with
>> anything that could possibly provide implementations of these functions.  It
>> *is* the provide, and it does not provde these symbols.  All this does is
>> create hundreds of warnings like:
>> incude/GL/glext.h:5570:45: warning: redundant redeclaration of 'glMultTransposeMatrixd' [-Wredundant-decls]
>> include/GL/gl.h:1940:45: note: previous declaration of 'glMultTransposeMatrixd' was here
> Huh?  When I look at the commit quoted, I see:
> -#define GL_GLEXT_PROTOTYPES /* we want prototypes */
> +#define GL_GLEXT_PROTOTYPES     /* we want prototypes */

Yeah... So I misread this as moving the /* from the beginning of the 
line to somewhere else in the line.  I only went looking for this after 
the tidalwave of warnings appeared in the build.  I assumed this was due 
to a recent change in GLX, but it seems that it was due to a recent 
change in the build.  Is -Wredundant-decls a useful warning?

Either way, the rest of the commit message is correct.  The only case 
where GL_GLEXT_PROTOTYPES should be defined is when linking with 
something that will provide those symbols.  The xserver does not link 
with anything that will provide these symbols.  Since the xserver is the 
driver loader, it is the thing that would / could provide these symbols, 
and it does not.

I think that it used to (and this define used to be necessary) back 
before the AIGLX work, but that was ages ago.

> The #define has actually been present since:
> commit 9508a382f8a9f241dab097d921b6d290c1c3a776
> Author: Kaleb Keithley<kaleb at freedesktop.org>
> Date:   Fri Nov 14 16:48:57 2003 +0000
>      Initial revision

More information about the xorg-devel mailing list