[PATCH 18/36] privates: when pixmap privates increase, bump the totalPixmapSize

Keith Packard keithp at keithp.com
Mon Jul 2 16:41:01 PDT 2012

Adam Jackson <ajax at nwnk.net> writes:

> On 7/2/12 6:13 AM, Dave Airlie wrote:
>> From: Dave Airlie <airlied at redhat.com>
>> This bumps totalPixmapSize in all attached screens.
> Aieee.  totalPixmapSize is now monotonically increasing every time you 
> plug something in.  Until it wraps, of course, and then bang.  Not sure 
> what a better solution looks like, but IWBNI host storage was shared if 
> possible.

Ok, so how about we fix the privates stuff so that drivers can allocate
per-screen private data by sticking a DevPrivateKeyRec inside their
screen private structure? And then we make it so you can allocate
per-screen private data after the server starts, but not other kinds?

I think that'll be pretty straightforward, shouldn't cause performance
regressions in drivers as they generally have a pointer to their screen
private where they're currently using privates.

With that, changing clients to use the serverClient mechanism for
privates (a pointer instead of a directly allocated chunk), and also
using that same scheme for glyphs and we should be able to make this work.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120702/c96369ef/attachment-0001.pgp>

More information about the xorg-devel mailing list