[PATCH 17/36] privates: remove asserts that stop dynamic increasing of privates size.
keithp at keithp.com
Mon Jul 2 16:26:00 PDT 2012
Dave Airlie <airlied at gmail.com> writes:
> From: Dave Airlie <airlied at redhat.com>
> These asserts stop us increasing the size of privates after create screen
> resources has been called, however for dynamic screens we need to be able
> to increase private size as new drivers are loaded.
> In theory any object allocated by an older driver won't try and use newer
> privates and any object allocated by a new driver should be okay.
I do believe this is wrong. As an example, the fine intel driver
allocates both PRIVATE_CLIENT and PRIVATE_GLYPH entries. Older
instances of both of those objects will not have space assigned.
Fixing clients would be pretty easy -- just use the serverClient
mechanism for all clients.
Glyphs seem a lot harder. The intel driver is cheating by knowing that
only one intel screen can be present. What we need are per-glyph
per-screen privates for drivers.
And, for other objects, privates should be allocated on a per-screen
basis. But, that seems even harder.
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 827 bytes
Desc: not available
More information about the xorg-devel