[PATCH 14/36] randr: expose unattached providers to the clients.

Keith Packard keithp at keithp.com
Mon Jul 2 15:48:30 PDT 2012


Dave Airlie <airlied at gmail.com> writes:

>  
>      if (pScrPriv->provider)
>          total_providers++;
> +    xorg_list_for_each_entry(iter, &pScreen->unattached_list, unattached_head) {
> +        pScrPriv = rrGetScrPriv(iter);
> +        total_providers += pScrPriv->provider ? 1 : 0;
> +    }
>  
>      pScrPriv = rrGetScrPriv(pScreen);

Probably should use a different variable to hold the GPU screen private
pointer? That way you wouldn't have to re-fetch after this loop.

Otherwise, this change looks fine to me.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120702/c6cdb91a/attachment.pgp>


More information about the xorg-devel mailing list