[PATCH 04/36] dix: introduce gpu screens. (v3)

[Adam Jackson]

On 7/2/12 6:12 AM, Dave Airlie wrote:

> +void
> +RemoveGPUScreen(ScreenPtr pScreen)
> +{
> +    int idx, j;
> +    if (!pScreen->isGPU)
> +        return;
> +
> +    idx = pScreen->myNum - GPU_SCREEN_OFFSET;
> +    for (j = idx; j < screenInfo.numGPUScreens - 1; j++) {
> +        screenInfo.gpuscreens[j] = screenInfo.gpuscreens[j + 1];
> +    }
> +    screenInfo.numGPUScreens--;
> +
> +    free(pScreen);
> +
> +}

I don't see this getting called from the xf86 DDX, at least not in 6/36.

Even if it were, it's not symmetric with how xf86's "remove" path works. 
  There you change ->scrnIndex to match the current slot in the array, 
here you're not doing that with ->myNum.  That seems like an error.

- ajax