[PATCH 1/2] os: fix vararg length calculation

Chase Douglas chase.douglas at canonical.com
Mon Jul 2 11:13:50 PDT 2012


On 06/28/2012 10:30 PM, Peter Hutterer wrote:
> Make %u and %x sizeof(unsigned int), %p sizeof(void*). This is printf
> behaviour and we can't guarantee that void* is uint64_t anyway.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> This needs to be squashed into:
>    Add LogMessageVerbSigSafe() for logging messages while in signal context
>
> Fixes the test/input crash on 32-bit userspace

This looks correct to me. For both patches:

Reviewed-by: Chase Douglas <chase.douglas@!canonical.com>


More information about the xorg-devel mailing list