[PATCH libXi 2/3] Drop grab_window from XIAllowTouch()

Chase Douglas chase.douglas at canonical.com
Tue Jan 31 11:51:25 PST 2012


On 01/31/2012 01:12 PM, Peter Hutterer wrote:
> On Tue, Jan 31, 2012 at 01:55:12AM +0100, Chase Douglas wrote:
>> On 01/27/2012 06:50 AM, Peter Hutterer wrote:
>>> grab_window was removed from the protocol, drop it from the public facing
>>> API. This argument was sent to the server but always ignored, clients can be
>>> fixed easily without seeing changed behaviour.
>>>
>>> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
>>> ---
>>>  include/X11/extensions/XInput2.h |    1 -
>>>  src/XIAllowEvents.c              |   10 +++++-----
>>>  2 files changed, 5 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/include/X11/extensions/XInput2.h b/include/X11/extensions/XInput2.h
>>> index 26de695..0fcddce 100644
>>> --- a/include/X11/extensions/XInput2.h
>>> +++ b/include/X11/extensions/XInput2.h
>>> @@ -455,7 +455,6 @@ extern Status XIAllowTouchEvents(
>>>      Display*            display,
>>>      int                 deviceid,
>>>      unsigned int        touchid,
>>> -    Window              grab_window,
>>>      int                 event_mode
>>>  );
>>
>> How will we extend the API when we do implement the grab window?
> 
> something like XIAllowTouchEventsOnWindow()?

Ok, fine by me.

I plan on reviewing everything in one big batch, so I'll wait on my
other question about the protocol changes before giving a reviewed-by.

-- Chase


More information about the xorg-devel mailing list