[PATCH] int10: Fix unmapping of the BIOS scratch area

Peter Hutterer peter.hutterer at who-t.net
Tue Jan 24 20:11:29 PST 2012


On Tue, Jan 24, 2012 at 05:35:04PM -0500, Adam Jackson wrote:
> 342f3eac8460fc48cfad1f1d7be939d671e6e1cd introduced a bug, 'base' is
> incremented before use.  The old code corrected this when unmapping, so
> the new code should too.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  hw/xfree86/int10/helper_exec.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/xfree86/int10/helper_exec.c b/hw/xfree86/int10/helper_exec.c
> index 638f566..03f9f7d 100644
> --- a/hw/xfree86/int10/helper_exec.c
> +++ b/hw/xfree86/int10/helper_exec.c
> @@ -726,7 +726,7 @@ xf86Int10SaveRestoreBIOSVars(xf86Int10InfoPtr pInt, Bool save)
>  	}
>      }
>      
> -    pci_device_unmap_legacy(pInt->dev, base, pagesize);
> +    pci_device_unmap_legacy(pInt->dev, base - BIOS_SCRATCH_OFF, pagesize);
>  }
>  #endif
>  
> -- 
> 1.7.7.5

Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>

Cheers,
  Peter


More information about the xorg-devel mailing list