[PATCH] Make --enable-internationalization default

[Thomas Dickey]

On Tue, Jan 24, 2012 at 01:34:06PM -0500, Gaetan Nadon wrote:
> On 12-01-23 06:04 PM, Matt Turner wrote:
> > xterm and gv need it.
> >
> > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45153
> >
> > Signed-off-by: Matt Turner <mattst88 at gmail.com>
> > ---
> >  configure.ac |    6 ++++--
> >  1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 8dd3984..8e47424 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -38,8 +38,10 @@ AC_TYPE_INTPTR_T
> >  XAW3D_CPPFLAGS=
> >  
> >  AC_ARG_ENABLE([internationalization],
> > -    [AS_HELP_STRING([--enable-internationalization], dnl
> > -     [enable utf8 strings])], [XAW3D_CPPFLAGS="${XAW3D_CPPFLAGS} -DXAW_INTERNATIONALIZATION"])
> > +    [AS_HELP_STRING([--disable-internationalization], dnl
> > +     [enable utf8 strings])], [enable_internationalization=no]
> > +     [XAW3D_CPPFLAGS="${XAW3D_CPPFLAGS} -DXAW_INTERNATIONALIZATION";
> > +      enable_internationalization=yes])
> >  
> >  AM_CONDITIONAL(XAW_INTERNATIONALIZATION,
> >      [test x${enable_internationalization} = xyes])
> It changes the default value of the --enable-internationalization
> feature from "no" to "yes". This isn't a bug. If the clients of libXaw3d
> require i18n, then they should configure libXaw3d this way when
> building. A case can be made to always enable i18n, but that is a
> separate discussion.
> 
> I am not in favor of changing the default value simply because we have
> found users for it. That was expected to begin with and I don't think
> Samuli was asking for that.

Actually the issue relative to xterm was reported over in GenToo this
week.  It seems that xorg changes have broken a more than 10-year old
packaging arrangement.

That's a bug in your code, and cannot be excused by citing a user request
to provide configurability.

awai

-- 
Thomas E. Dickey <dickey at invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120124/bbdb06b5/attachment.pgp>