[PATCH] Include XAW3D_CPPFLAGS in xaw3d.pc Cflags

[Gaetan Nadon]

On 12-01-24 01:34 PM, Gaetan Nadon wrote:
> On 12-01-23 03:06 PM, Matt Turner wrote:
>> Software depending on libXaw3d seems to require this.
>>
>> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45144
>>
>> Signed-off-by: Matt Turner <mattst88 at gmail.com>
>> ---
>>  xaw3d.pc.in |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/xaw3d.pc.in b/xaw3d.pc.in
>> index b243c52..f53fca5 100644
>> --- a/xaw3d.pc.in
>> +++ b/xaw3d.pc.in
>> @@ -8,5 +8,5 @@ Description: X 3D Athena Widgets Library
>>  Version: @PACKAGE_VERSION@
>>  Requires: xproto xmu xt
>>  Requires.private: x11 xext
>> -Cflags: -I${includedir}
>> +Cflags: -I${includedir} @XAW3D_CPPFLAGS@
>>  Libs: -L${libdir} -lXaw3d
> Make sure that this is Ok for the other three features (bitmaps,
> stipples and scrollbars. If not, use a different variable name than
> XAW3D_CPPFLAGS. Their Cflags is going to end up there as well and there
> may be  a naming clash. You need to check the source code for usage.
>
> Oh, wait a minute. There is a reason why it is not there to begin with.
> Isn't it a "private" header? Making it public will make it impossible to
> make backward compatible changes. Code written for xaw3d may want to be
> ported on xaw and will put pressure on libxaw to make it public as well.
>
> If gv wants to break the rule and use private header, they have to do
> the workarounds. That is what usually the capital P stands for, but I
> could be wrong.

It all checks out ok.

Reviewed-by: Gaetan Nadon <memsize at videotron.ca>


>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>