[PATCH app-xlsclients] configure.ac: regroup statements and comment

Alan Coopersmith alan.coopersmith at oracle.com
Mon Jan 23 19:03:01 PST 2012


On 01/22/12 05:24 PM, Gaetan Nadon wrote:
> Add missing AC_CONFIG_SRCDIR([Makefile.am])
>
> Move AC_USE_SYSTEM_EXTENSIONS higher up in Autoconf init section
> which must come before XORG_DEFAULT_OPTIONS
>
> Move XORG_DEFAULT_OPTIONS to its usual place with X.Org macros
> Note that AC_FUNC_STRNLEN calls AC_REQUIRE(AC_USE_SYSTEM_EXTENSIONS)
>
> Comment the strnlen function replacement.
>
> No functional changes. Following the layout in
> http://www.x.org/wiki/NewModuleGuidelines
>
> Signed-off-by: Gaetan Nadon<memsize at videotron.ca>

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

> +# Use strnlen GNU extension or the implementation supplied in this module

While it was originally a GNU extension, strnlen() has been added to the POSIX
standard in the 2008 revision, so isn't only GNU any more.

http://pubs.opengroup.org/onlinepubs/9699919799/functions/strlen.html

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list