[PATCH 1.12] A coding style for the server

Chase Douglas chase.douglas at canonical.com
Wed Jan 18 11:37:00 PST 2012


On 01/18/2012 04:02 AM, Daniel Stone wrote:
> I'd like to see this merged for 1.12, despite the merge window having
> shut, so patches for 1.13's master are more likely to apply to 1.12.
> It's arguably not the best time to do it, but there is no good time.

As a downstream that is doing a one-off franken-server, it would be very
annoying for this change to be applied directly to 1.12.

A bit of background: Ubuntu has been shipping a prototype implementation
of XInput multitouch since 11.04. The next release is a long-term
support (LTS) release. We did not want to have conflicting XInput
implementations wrt upstream for an LTS, so we decided we must have the
1.12 input implementation.

However, this being an LTS cycle, our feature freeze deadline is earlier
than normal. On top of that, we must have all the proprietary binary
drivers for the server by feature freeze. Unfortunately, this isn't
possible for 1.12.

So we are going to be shipping a franken-server 1.11 + 1.12 input
backport. Perhaps surprisingly, no issues have been found at all in
testing, and we are about to push it into the main archive at the end of
this week or early next.

We are only one downstream, so I don't feel we should have veto power
over this change. However, it really would make our lives much harder if
this were applied to 1.12, so please have mercy on us :).

All that said, I really would like a formal coding style as well. I
would be all for applying this to 1.13.

-- Chase


More information about the xorg-devel mailing list