[Intel-gfx] [PATCH] Android port of intel-gpu-tools

[Daniel Vetter]

On Mon, Jan 16, 2012 at 10:25:32AM -0800, Chad Versace wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 01/10/2012 04:47 AM, Daniel Vetter wrote:
> > On Tue, Jan 10, 2012 at 10:15:01AM +0530, Sateesh Kavuri wrote:
> >> Added support for Android. Changes include fixes for compilation issues
> >>  related to Android using an older version of GCC compiler (ver 4.3.3)
> >>  while the latest version of intel-gpu-tools confirms to GCC ver 4.5.2
> >>  (C99 standard functions), using functions like getline(). Fixed such
> >>  functions, header dependencies for android and added an Android.mk file.
> >>
> >> signed-off-by: Sateesh Kavuri <sateesh.kavuri at intel.com>
> > 
> > A few comments
> > - It looks like you need a completely separate makefile for android. Is
> >   there no way to let the automake tools generate that somehow? Because
> >   this simply won't scale.
> > 
> > - There's too much ANDRIOD #ifdef'ery in the code. Either switch to a
> >   construct that works on all platforms or extract things into a little
> >   helper functions (like the get_total_ram helper that has recently been
> >   ported to Solaris).
> > 
> > - You don't seem to touch the testsuite, and I think you want it on
> >   Andriod, too.
> > 
> > Added xorg-devel to cc, maybe someone else has already tried this with a
> > different package, my buildsystem fu is not up to this.
> > 
> > Yours, Daniel
> 
> Daniel, the Android.mk's are the curse of every project that is ported to
> Android.  Android has it's own build system, and those makefiles can't be
> generated with autotools.  This was a contentious issue when Chia-I Wu and
> I ported Mesa to Android and led to a discussion [1] on mesa-dev. Below is
> quoted my key email from that discussion (the Dan I'm speaking to is a Debian
> maitainer).
> 
> [1] http://article.gmane.org/gmane.comp.video.mesa3d.devel/28881/match=add+toplevel+android+mk

Meh.

I've just read about androgenizer:

http://cgit.collabora.com/git/user/derek/androgenizer.git/

Would that be a useful to at least generate the Android.mk in a sensible
fashion? I don't have clue about this ...

Otherwise we'll just stick Android.mk into the root dir and I'll forget
about this (and probably break it every time I change something).
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48