[PATCH intel-gpu-tools v2 0/6] Convert debugger to Automake

Daniel Vetter daniel at ffwll.ch
Tue Jan 10 01:05:45 PST 2012


On Mon, Jan 09, 2012 at 09:26:14PM -0800, Ben Widawsky wrote:
> On Fri, Jan 06, 2012 at 06:25:04PM -0500, Gaetan Nadon wrote:
> > Version 2 improves commit messages and custom build commands
> > 
> > Also fixed some nits in other makefiles.
> > 
> > I checked that the binaries produced have the same size, but I'd like
> > someone to run a sanity check on the module. I ran distcheck,
> > out-of-source build and build from tarball. 
> > A Tested-by tag would be appreciated.
> > 
> > I'll be away for the next few days. I'll collect review tags and I'll
> > push the patches next week if all goes well.
> > 
> > Gaetan Nadon (6):
> >   Debugger: convert existing makefiles to Automake.
> >   Benchmark: use correct src and build location
> >   lib: fix include directives, alphabetize sources
> >   scripts: use PYTHON primary directive for python scripts
> >   tools: use correct src and build location
> >   config: remove unused AC_DEFINE for CAIRO, LIBUDEV and GLIB
> > 
> >  Makefile.am                            |    8 ++--
> >  benchmarks/Makefile.am                 |   29 +++--------
> >  configure.ac                           |   60 +++++++++++++++--------
> >  debugger/Makefile.am                   |   27 +++++------
> >  debugger/system_routine/.gitignore     |   12 ++++-
> >  debugger/system_routine/GNUmakefile.in |    3 -
> >  debugger/system_routine/Makefile       |   84 --------------------------------
> >  debugger/system_routine/Makefile.am    |   42 ++++++++++++++++
> >  lib/Makefile.am                        |   45 ++++++++---------
> >  scripts/Makefile.am                    |    7 +--
> >  tools/Makefile.am                      |   78 ++++++++++++++----------------
> >  11 files changed, 174 insertions(+), 221 deletions(-)
> >  delete mode 100644 debugger/system_routine/GNUmakefile.in
> >  delete mode 100644 debugger/system_routine/Makefile
> >  create mode 100644 debugger/system_routine/Makefile.am
> 
> Acked-by: Ben Widawsky <ben at bwidawsk.net>

I've just wanted to slurp these in but stumbled over a small conflict with
Alan's solaris stuff. If you have commit access, please go wild. Otherwise
I could try again, but my own buildsystem-fu is barely good enough to make
things compile ;-)

Thanks for your awesome work, Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48


More information about the xorg-devel mailing list