[PATCH] render: don't bother with animated cursors on floating slaves (#39989)

Jeremy Huddleston jeremyhu at apple.com
Mon Jan 9 14:46:12 PST 2012


Sounds reasonable

Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

Sent from my iPad

On Jan 8, 2012, at 17:20, Peter Hutterer <peter.hutterer at who-t.net> wrote:

> In the case of floating slave devices that is reattached to a master with an
> animated cursor, that cursor may "jump outside" it's window confines. Since
> floating slaves never display a cursor anyway, we might as well short-cut
> this and exit early.
> 
> X.Org Bug 39989 <http://bugs.freedesktop.org/show_bug.cgi?id=39989>
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> Tested-by: Harald Judt <h.judt at gmx.at>
> --- 
> render/animcur.c |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/render/animcur.c b/render/animcur.c
> index 4cf1fdf..0f174fd 100644
> --- a/render/animcur.c
> +++ b/render/animcur.c
> @@ -208,6 +208,9 @@ AnimCurDisplayCursor (DeviceIntPtr pDev,
>     AnimCurScreenPtr    as = GetAnimCurScreen(pScreen);
>     Bool        ret;
> 
> +    if (IsFloating(pDev))
> +        return FALSE;
> +
>     Unwrap (as, pScreen, DisplayCursor);
>     if (IsAnimCur(pCursor))
>     {
> -- 
> 1.7.7.4
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
> 


More information about the xorg-devel mailing list