[PATCH] Change autogen.sh scripts to respect NOCONFIGURE

Eric Anholt eric at anholt.net
Thu Jan 5 19:24:13 PST 2012


On Thu, 05 Jan 2012 11:41:46 -0500, Gaetan Nadon <memsize at videotron.ca> wrote:
> On 12-01-05 09:17 AM, Colin Walters wrote:
> > Hi Gaetan,
> >
> > On Wed, 2012-01-04 at 19:48 -0500, Gaetan Nadon wrote:
> >
> >> No objections in principle, the doc is convincing.
> >>
> >> We are talking about 240 modules here. A sizable piece of work.
> > Thanks; any suggestions on how to proceed?  I don't have commit
> > privileges to the xorg repositories (and no need to get them for such a
> > trivial patch), should I go through individual maintainers or should
> > someone Just Do It?
> >
> > One thing we might want to consider before we change all 240 modules is
> > instead changing xorg-macros to install its autogen.sh as
> > $prefix/bin/xorg-autogen.sh or something, then all of the xorg autogen
> > scripts can just be:
> >
> > #!/bin/sh
> > exec xorg-autogen.sh "$@"
> >
> > This is effectively what we do with gnome-common, except some random
> > modules still have hand-written ones.  Consistency - not yet our strong
> > point =/
> >
> 
> Seems like a brilliant idea. We can then make changes to xorg-autogen.sh
> in the future without having to commit 240 patches. I'd be willing to
> change all the xorg modules. There is an assumption that all modules
> will be configured with the same BINDIR value, or that at least
> xorg-autogen.sh in on the PATH. Looks reasonable.
> 
> Could you create the patch for the util-macros package? Making sure it
> works on a Bourne shell for all *BSD, MAC and Solaris OS. It will get
> reviewed on the list and I'll give a good run. If all goes well, a new
> version of xorg-macros will be published.
> 
> Note that I will also have to update configure.ac in each module to
> mandate the latest version of xorg-macros (as usual):
> XORG_MACROS_VERSION(1.17)

Given how many people's first interaction with xorg-macros is
configure.ac telling them that it's out of date/missing, I'm not excited
about modules now just saying command not found instead of giving useful
information.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120105/5c2567e4/attachment-0001.pgp>


More information about the xorg-devel mailing list