[PATCH XTS v2 2/2] xts5: fix XSetDeviceFocus-5

Peter Hutterer peter.hutterer at who-t.net
Thu Jan 5 14:48:57 PST 2012


On Thu, Jan 05, 2012 at 02:41:31PM -0800, Chase Douglas wrote:
> On 01/05/2012 02:28 PM, Peter Hutterer wrote:
> > t003() selects for key events on the root window. t005() takes over and then
> > complains when the focus correctly follows the pointer and an event is
> > delivered to the root window. If you don't expect events on the root window,
> > unselect them first.
> > 
> > We could also XCloseDisplay() at the end of each test but who knows what that
> > does to the other tests.
> > 
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> > Reviewed-by: Chase Douglas <chase.douglas at canonical.com>
> > ---
> > Changes to v1:
> > - hah! there is a macro for the "no event" class after all. use that.
> > 
> > Chase, I figured your rev-by still stands given that this is the same effect
> > but much saner.
> 
> Yes, though "yuck" still stands from an API perspective :).

it's not the worst bit of the libXi API...

Cheers,
  Peter


More information about the xorg-devel mailing list