[PATCH XTS 2/2] xts5: remove (type *)NULL casts

Alan Coopersmith alan.coopersmith at oracle.com
Wed Jan 4 21:21:16 PST 2012


On 01/04/12 21:01, Peter Hutterer wrote:

> --- a/xts5/XI/XGetDeviceKeyMapping.m
> +++ b/xts5/XI/XGetDeviceKeyMapping.m
> @@ -267,8 +267,8 @@ int 	SymsPerCode = 6;
>
>   	CHECKPASS(1);
>   >>ASSERTION def
> ->># I'm not sure what you could do here, its just saying that there is
> ->># a reserved value that means 'not used'.
> +>># I'm' not sure what you could do here, its just saying that there is
> +>># a reserved value that means 'n'ot used'.'
>   When an element for a particular KeyCode is unused,
>   then a KeySym value of
>   .S NoSymbol

What's the ' insertion in that hunk for?  Seems a bit weird - almost like
cocinelle is trying to form valid C character literals by inserting a second
' one char after each existing one.


> diff --git a/xts5/Xlib11/GraphicsExpose.m b/xts5/Xlib11/GraphicsExpose.m
> index 8db2f94..8150edd 100644
> --- a/xts5/Xlib11/GraphicsExpose.m
> +++ b/xts5/Xlib11/GraphicsExpose.m
> @@ -257,7 +257,7 @@ unsigned int	width;
>   >>#NOTEs and
>   >>#NOTEs .M y
>   >>#NOTEs are set to
> ->>#NOTEs the coordinates relative to the window's origin
> +>>#NOTEs the coordinates relative to the window's' origin
>   >>#NOTEs and indicate the upper-left corner of the rectangle defining the exposed region.
>   >>#NOTEs>>ASSERTION
>   >>#NOTEs When ARTICLE xname event is delivered,

Same here and a bunch more interspersed throughout.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list