[PATCH 11/31] mi: _X_UNEXPORT

Peter Hutterer peter.hutterer at who-t.net
Wed Jan 4 15:33:49 PST 2012


On Wed, Jan 04, 2012 at 11:11:55PM +0000, Daniel Stone wrote:
> Hi,
> 
> On Wed, Dec 07, 2011 at 08:40:41AM +1000, Peter Hutterer wrote:
> > On Fri, Dec 02, 2011 at 11:31:17AM +0000, Daniel Stone wrote:
> > > Remove unnecessary _X_EXPORT tags from mi headers.
> > > 
> > > Signed-off-by: Daniel Stone <daniel at fooishbar.org>
> > 
> > some of these are still used by input drivers, most likely in error. I won't
> > have time to go through those drivers to fix them up right now, so it may be
> > better to leave those used alone for now.
> > I found occurances of the following but I didn't check for ABI checks on
> > those so double-checking would be good:
> >     miPointerGetScreen()
> >     miPointerSetPosition()
> >     miPointerCurrentScreen()
> > 
> > I also suspect that VNC may use some of these.
> 
> miPointerCurrentScreen was never used with current ABI; they were all
> #ifdefed to use miPointerGetScreen instead.  So I've unexported
> GetScreen.  I couldn't find any occurrence of miPointerSetPosition in
> any of my driver checkouts though?

the sis driver uses it, after miPointerAbsoluteCursor got removed, I only
sent out that patch yesterday: http://patchwork.freedesktop.org/patch/8595/
(after an earlier one last year that didn't handle ABIs at all)
Though the value of that is debatable in any case.

Cheers,
  Peter


More information about the xorg-devel mailing list