[PATCH 08/31] os: _X_UNEXPORT

[Daniel Stone]

On Fri, Dec 02, 2011 at 12:33:46PM -0800, Alan Coopersmith wrote:
> On 12/02/11 03:31, Daniel Stone wrote:
> >diff --git a/include/dixstruct.h b/include/dixstruct.h
> >index 0a85f40..1a4aece 100644
> >--- a/include/dixstruct.h
> >+++ b/include/dixstruct.h
> >@@ -38,7 +38,7 @@ SOFTWARE.
> >   *      translation from client ids to server addresses.
> >   */
> >
> >-extern _X_EXPORT CallbackListPtr ClientStateCallback;
> >+extern CallbackListPtr ClientStateCallback;
> >
> >  typedef struct {
> >      ClientPtr 		client;
> 
> Oh, that's what I get for reading out of order - this seems to
> pair with the addition of it in the .c file in the DIX patch.
> Shouldn't dixstruct.h actually be in the DIX patch?

Oops yes, thanks.

> >-extern _X_EXPORT int set_font_authorizations(
> >+extern int set_font_authorizations
> 
> That's another one that libXfont calls back to for font server setup.
> (Would be nice to have a proper callback API instead of just weak
>  symbols and lazy linking, but that's what we've got for now.)

Ah, good catch.  I've re-exported that, thanks.

Cheers,
Daniel