[PATCH v2 08/42] Move extension initialisation prototypes into extinit.h

Daniel Stone daniel at fooishbar.org
Wed Jan 4 10:42:48 PST 2012


Hi,

On Wed, Dec 07, 2011 at 09:44:23AM +1000, Peter Hutterer wrote:
> On Fri, Dec 02, 2011 at 11:27:16AM +0000, Daniel Stone wrote:
> > Create extinit.h (and xf86Extensions.h, for Xorg-specific extensions) to
> > hold all our extension initialisation prototypes, rather than
> > duplicating them everywhere.
> > 
> > Signed-off-by: Daniel Stone <daniel at fooishbar.org>
> 
> Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
> any specific reason that DRIExtensionInit() gets special treatment?

Because it's part of the supporting code called by the _real_ extension
initialisation.  So, in XFree86, XFree86DRIExtensionInit would be called
to set up XFree86-DRI, and as part of that, it'd call DRIExtensionInit
which would set up the base supporting code.

> the "#if 1" could be removed as well, or alternatively should be added to
> all built-in ones (Render, GE, Shape, ...)

Er, it has been?

Cheers,
Daniel


More information about the xorg-devel mailing list