[PATCH xserver 1/1] os: Pass the FatalError message to OsVendorFatalError

Jon TURNEY jon.turney at dronecode.org.uk
Mon Feb 20 04:09:10 PST 2012


On 19/02/2012 22:42, Jeremy Huddleston wrote:
> Ping.  I know this looks pointless, but I need it for a follwup patch which uses this info in XQuartz's OsVendorFatalError.

I suspect I have the same use, so:

Reviewed-by: Jon TURNEY <jon.turney at dronecode.org.uk>

> On Feb 17, 2012, at 1:47 PM, Jeremy Huddleston <jeremyhu-2kanFRK1NckAvxtiuMwx3w at public.gmane.org> wrote:
>> diff --git a/hw/dmx/dmxlog.c b/hw/dmx/dmxlog.c
>> index 94b8035..0ebe9f9 100644
>> --- a/hw/dmx/dmxlog.c
>> +++ b/hw/dmx/dmxlog.c
>> @@ -102,9 +102,6 @@ static void VFatalError(const char *format, va_list args)
>> {
>>     VErrorF(format, args);
>>     ErrorF("\n");
>> -#ifdef DDXOSFATALERROR
>> -    OsVendorFatalError();
>> -#endif

This looks like it's already wrong, and should have been a call to
OsVendorFatalError() since DDXOSFATALERROR got removed in commit 16e40ecf?

>> diff --git a/os/log.c b/os/log.c
>> index 671a01b..cdff7d1 100644
>> --- a/os/log.c
>> +++ b/os/log.c
>> @@ -585,6 +585,7 @@ void
>> FatalError(const char *f, ...)
>> {
>>     va_list args;
>> +    va_list args2;

Incorrect (or at least, different to the line above) whitespace?


More information about the xorg-devel mailing list