[PATCH Xaw3D] fix segfaults on tip popups. #46124

[Matt Turner]

On Wed, Feb 15, 2012 at 2:05 PM, Devin J. Pohly <djpohly+xorg at gmail.com> wrote:
> From: "Devin J. Pohly" <djpohly+xorg at gmail.com>
>
> When XAW_INTERNATIONALIZATION isn't defined, some uninitialized stack
> data was being passed to XtGetValues.  This makes it not do that.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=46124
> Signed-off-by: Devin J. Pohly <djpohly+xorg at gmail.com>
> ---
>  src/Tip.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/src/Tip.c b/src/Tip.c
> index 5f54d14..5542fc5 100644
> --- a/src/Tip.c
> +++ b/src/Tip.c
> @@ -606,8 +606,10 @@ TipTimeoutCallback(XtPointer closure, XtIntervalId *id)
>  #ifdef XAW_INTERNATIONALIZATION
>     info->tip->tip.international = False;
>     XtSetArg(args[1], XtNinternational, &info->tip->tip.international);
> -#endif
>     XtGetValues(winfo->widget, args, 2);
> +#else
> +    XtGetValues(winfo->widget, args, 1);
> +#endif
>
>     TipLayout(info);
>     TipPosition(info);
> --
> 1.7.9

Looks good to me. Thanks, I'll apply it. :)