[PATCH] render: don't bother with animated cursors on floating slaves (#39989)
Jon TURNEY
jon.turney at dronecode.org.uk
Wed Feb 15 06:22:02 PST 2012
On 26/01/2012 21:43, Colin Harrison wrote:
> On my Windows build this patch...
>
> diff --git a/render/animcur.c b/render/animcur.c
> index 4cf1fdf..0f174fd 100644
> --- a/render/animcur.c
> +++ b/render/animcur.c
> @@ -208,6 +208,9 @@ AnimCurDisplayCursor (DeviceIntPtr pDev,
> AnimCurScreenPtr as = GetAnimCurScreen(pScreen);
> Bool ret;
>
> + if (IsFloating(pDev))
> + return FALSE;
> +
> Unwrap (as, pScreen, DisplayCursor);
> if (IsAnimCur(pCursor))
> {
>
> causes the 'default' cursor to disappear...(I like to party_like_its 1989!)
>
> I always need a cursor as when the X root window isn't hidden on Windows you
> can't easily control anything as the 'black or stippled X window' blots out
> Microsoft's stuff :)
I did a bit of testing with -retro and the Xorg DDX, and I see the same thing,
the saltire cursor is missing initially.
However, reverting this commit didn't help. This seems to be a regression
since 1.10, present in 1.11. Bisecting pointed to dc57f89 "Switch to use
IsFloating()"
More information about the xorg-devel
mailing list