[PATCH 2/4] Fix redundant declarations in dixfont.h

[Jon TURNEY]

On 29/01/2012 17:27, Alan Coopersmith wrote:
> On 01/27/12 07:55 AM, Jon TURNEY wrote:
>> These functions (which are required by libXfont) are prototyped in
>> fontproto.h, which is included
>> (indirectly, at the moment) by dixfont.h.  It seems sensible to remove the
>> declarations from dixfonts.h
>> and make the include explicit
> 
> It seems sensible, and I'd be totally in favor of it... except for
> sdksyms.sh in the xfree86 ddx build, which searches headers for
> _X_EXPORT symbols to export.    If we make this change, will these
> symbols stop being exported and then we get stuck using the weak
> linked stubs in libXfont?

Possibly, if there are no other references to those symbols in the xorg DDX.

I'm not sure what to do about this without making the sdksyms mechanism even
worse.  I suppose these declarations in dixfont.h could be wrapped in #if 0 or
#ifdef SDKSYMS/#endif (where SDKSYMS is a symbol which is never defined when
building)

Tbh, I'm not sure what the arguments were for turning the -Wredundant-decls
warning on, i.e. what class of errors it protects against.