[PATCH synaptics 4/5] Don't initialize semi-multitouch devices for touch device class

Chase Douglas chase.douglas at canonical.com
Thu Feb 2 13:06:43 PST 2012


On 02/02/2012 09:08 AM, Jussi Pakkanen wrote:
> On 02/02/2012 01:50 AM, Chase Douglas wrote:
> 
>> +    if (rc>= 0&&  (prop&  INPUT_PROP_SEMI_MT))
> 
> Input props are defined like this:
> 
> #define INPUT_PROP_POINTER              0x00
> #define INPUT_PROP_DIRECT               0x01
> #define INPUT_PROP_BUTTONPAD            0x02
> #define INPUT_PROP_SEMI_MT              0x03
> 
> Thus rather than and'ing, you should be using BitIsOn or equivalent.

Oh yeah, thanks for catching this again. I copied this from a broken
implementation.

-- Chase


More information about the xorg-devel mailing list