[PATCH] dix: don't copy the wrong event mask when activating a passive grab
Keith Packard
keithp at keithp.com
Mon Dec 17 13:55:19 PST 2012
Peter Hutterer <peter.hutterer at who-t.net> writes:
> GrabMask is a union of core, XI1 and XI2 masks. If a XI2 grab is activated,
> the value is a random pointer value, using it as mask has unpredictable
> effects.
The comment is a bit misleading -- GrabMask is a union of core and XI1 masks
and a *pointer* to XI2 masks.
I'm assuming there's nothing in any of the XI2 masks which you want to
stuff in grab->eventMask, right?
In any case, 0 is better than garbage.
Reviewed-by: Keith Packard <keithp at keithp.com>
--
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20121217/b37901ce/attachment.pgp>
More information about the xorg-devel
mailing list