[PATCH v2] xf86: Fix non-PCI configuration-less setups

Dave Airlie airlied at gmail.com
Tue Dec 11 18:54:41 PST 2012


On Wed, Dec 12, 2012 at 11:49 AM, Dave Airlie <airlied at gmail.com> wrote:
> So this got merged into Fedora, and nobody reads bug reports after
> merging stuff to know when it breaks lots of things.
>>      }
>>
>> +    /*
>> +     * If all of the above fails, which can happen if X was started without
>> +     * configuration or if BusID wasn't set for non-PCI devices, use the first
>> +     * device by default.
>> +     */
>> +    if (!foundScreen && xf86_num_platform_devices > 0 && numDevs > 0)
>> +        foundScreen = probeSingleDevice(&xf86_platform_devices[0], drvp, devList[0], 0);
>> +
>
> So this patch doesn't get foundScreen right at all, I've got a fix I'm
> just testing now, though it just shows that the code originally was
> broken, but we didn't notice!

Okay my initial fix was even more bogus than this patch was, but
anyways, lets get it out of master, and Thierry you can go try again!

I'm getting other distros merged this as well, so hopefully they know
to remove it.

But here on a dual-gpu machine, with that patch, I end up running in
two X desktop mode, instead of landing in master/slave GPU mode, this
means XINERAMA doesn't get enabled, and lots of stuff falls apart.

Dave.


More information about the xorg-devel mailing list