[PATCH xf86-input-mouse] Fix "attempting to log data in a signal unsafe manner" warning

Markus Trippelsdorf markus at trippelsdorf.de
Fri Aug 31 09:13:07 PDT 2012


(EE) BUG: triggered 'if (inSignalContext)'
(EE) BUG: /var/tmp/portage/x11-base/xorg-server-1.12.99.905/work/xorg-server-1.12.99.905/os/log.c:472 in LogVMessageVerb()
(EE) Warning: attempting to log data in a signal unsafe manner while in signal context. Please update to check inSignalContext and/or use LogMessageV
erbSigSafe() or ErrorFSigSafe(). The offending log format message is:
3rd Button detected: disabling emulate3Button

(EE) 
(EE) Backtrace:
(EE) 0: /usr/bin/X (xorg_backtrace+0x36) [0x57ef76]
(EE) 1: /usr/bin/X (LogVMessageVerb+0x64) [0x5897c4]
(EE) 2: /usr/bin/X (xf86Msg+0x8f) [0x47e20f]
(EE) 3: /usr/lib64/xorg/modules/input/mouse_drv.so (0x7f4d66caf000+0x6fda) [0x7f4d66cb5fda]
...

diff --git a/src/mouse.c b/src/mouse.c
index b65ea0e..b91efc3 100644
--- a/src/mouse.c
+++ b/src/mouse.c
@@ -2046,7 +2046,7 @@ Emulate3ButtonsSoft(InputInfoPtr pInfo)
     if (!pMse->emulate3ButtonsSoft)
         return TRUE;
 
-    xf86Msg(X_INFO,"3rd Button detected: disabling emulate3Button\n");
+    LogMessageVerbSigSafe(X_INFO,0,"3rd Button detected: disabling emulate3Button\n");
 
     Emulate3ButtonsSetEnabled(pInfo, FALSE);
 
-- 
Markus


More information about the xorg-devel mailing list