[PATCH] dix: free default colormap before screen deletion

Keith Packard keithp at keithp.com
Wed Aug 29 13:54:17 PDT 2012

Dave Airlie <airlied at gmail.com> writes:

> From: Dave Airlie <airlied at redhat.com>
> If we don't free this here, it gets freed later in the resource
> cleanups, however it then looks up up pmap->pScreen, which we
> freed already in this function. So free the default colormap
> when we should.

Is there anything else hanging off of a GPU screen that also needs to
get freed here? I don't think so, but this would be a good time to make sure.

I'd love to have the commit comment in the code as well so that we don't
see the free later and think 'why do this one specially?'

Reviewed-by: Keith Packard <keithp at keithp.com>

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120829/2f03d8ee/attachment-0001.pgp>

More information about the xorg-devel mailing list