[PATCH vesa 2/2] Fix check function in VESASaveRestore

[Peter Hutterer]

On Wed, Aug 22, 2012 at 09:19:59AM +0500, Alexandr Shadchin wrote:
> On Mon, Aug 20, 2012 at 6:00 AM, Peter Hutterer
> <peter.hutterer at who-t.net> wrote:
> > On Sat, Aug 18, 2012 at 08:53:34PM +0600, Alexandr Shadchin wrote:
> >> Signed-off-by: Alexandr Shadchin <Alexandr.Shadchin at gmail.com>
> >> ---
> >>  src/vesa.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/src/vesa.c b/src/vesa.c
> >> index 8ac77da..11cd26c 100644
> >> --- a/src/vesa.c
> >> +++ b/src/vesa.c
> >> @@ -1626,7 +1626,7 @@ VESASaveRestore(ScrnInfoPtr pScrn, vbeSaveRestoreFunction function)
> >>  {
> >>      VESAPtr pVesa;
> >>
> >> -    if (MODE_QUERY < 0 || function > MODE_RESTORE)
> >> +    if (function < MODE_QUERY || function > MODE_RESTORE)
> >>       return (FALSE);
> >>
> >>      pVesa = VESAGetRec(pScrn);
> >> --
> >> 1.7.6
> >
> > certainly looks less broken than the previous one though I notice that the
> > previous one has been in since the original import in 2003.
> >
> > what was the effect of this bug? a small blurb in the commit message would
> > be appreciated.
> >
> > Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
> >
> > Cheers,
> >    Peter
> >
> 
> No effect, just corrected strange condition :)
> VESASaveRestore() call only with MODE_SAVE and MODE_RESTORE.
> 
> Need send pull request or someone push?
> 
pushed, thanks

Cheers,
   Peter