[PULL] sigsafe logging and other fixes

Keith Packard keithp at keithp.com
Wed Aug 22 13:52:16 PDT 2012

Peter Hutterer <peter.hutterer at who-t.net> writes:

> Two unreviewed: the win32 fsync ifdef typo, and the fix for 53568, which
> currently crashes on the first pointer event from an Option Floating device.

I've reviewed those now.

>       mi: don't check for core events in miPointerSetPosition (#53568)

This seems very much like a 'how could that ever have been the right
idea' kind of change to me -- setting the pointer position for a device
shouldn't ever have depended on whether that device was delivering core
events or not. In any case, the change seems obviously correct to me

Reviewed-by: Keith Packard <keithp at keithp.com>

However, this still looks very fragile -- fill_pointer_events does not
check the return value from miPointerSetPosition, which is still allowed
to return NULL in some cases. I don't think any of those are valid
though, so I'd suggest that either miPointerSetPosition or
positionSprite throw a fatal error instead of blindly wandering into a

>       os: fix typo, fsync when WIN32 is _not_ defined

Reviewed-by: Keith Packard <keithp at keithp.com>

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120822/4a73ef08/attachment.pgp>

More information about the xorg-devel mailing list