[PATCH] mi: don't check for core events in miPointerSetPosition (#53568)

Peter Hutterer peter.hutterer at who-t.net
Wed Aug 15 21:01:10 PDT 2012

As of 81cfe44b1ed0de84ad1941fe2ca74bebef3fc58d, miPointerSetPosition now
returns the screen pointer of the device. This broke floating slave devices,
as soon as a motion event was submitted, miPointerSetPosition returned NULL,
crashing the server.

dev->coreEvents is only false if the device is a floating slave, in which
case it has a sprite.

X.Org Bug 53568 <http://bugs.freedesktop.org/show_bug.cgi?id=53568>

Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
 mi/mipointer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mi/mipointer.c b/mi/mipointer.c
index a56838e..4defaf5 100644
--- a/mi/mipointer.c
+++ b/mi/mipointer.c
@@ -575,7 +575,7 @@ miPointerSetPosition(DeviceIntPtr pDev, int mode, double *screenx,
     miPointerPtr pPointer;
-    if (!pDev || !pDev->coreEvents)
+    if (!pDev)
         return NULL;
     pPointer = MIPOINTER(pDev);

More information about the xorg-devel mailing list