[PATCH libXaw] Publish API feature tokens via Xaw3dP.h (#46846)

Matt Turner mattst88 at gmail.com
Wed Aug 8 21:00:53 PDT 2012


On Wed, Aug 8, 2012 at 5:36 PM, Daniel Macks <dmacks at netspace.org> wrote:
> Attached patch fixes bugzilla item.

For future reference:

 - libXaw3d, not libXaw
 - please send patches inline, preferably via git send-email
 - If you do sent attached patches, make sure they're acceptable to
git-am (yours wasn't)

> +BUILT_SOURCES = X11/Xaw3d/Xaw3dP.h
> +X11/Xaw3d/Xaw3dP.h: X11/Xaw3d/Xaw3dP.h.in

That doesn't seem right for a file generated by configure.ac. Is it?

I'm really not convinced that we should re-add this file to v1.6. The
Xaw3dP.h header file even says

/*
 * Global definitions and declarations. Not for public consumption.
 */

We fixed up a couple of packages to use pkg-config when I added
libXaw3d-1.6 to Gentoo, but it wasn't anything serious. It's not like
much software uses this library anyway.

Then again, I really don't care to do any more work to libXaw3d, so
I'm not sure my opinion counts.


More information about the xorg-devel mailing list