[PATCH 3/3]siliconmotion new driver initial patch 3

Michal Suchanek hramrach at gmail.com
Mon Aug 6 05:27:45 PDT 2012

On 6 August 2012 11:50, Aaron.Chen  陈俊杰 <aaron.chen at siliconmotion.com> wrote:
> We've updated the configuration for compiling because the change of source code.

Again, when introducing source changes requires build system changes
those should be introduced in one patch. This renders this patch
bogus. Obviously it is either not required or the driver is not
buildable after applying patch 2.

Also you reformat whole copyright notice to change ".. in no event
Adam Jackson should be .." to ".. in no event the authors should be
..". This is still merge fail.

Another merge fails is adding another copy of the copyright notice in
numerous files.

I see that there is non-advertising clause in some files where you add
another copyright notice but then you are mostly included as copyright
holder anyway so just updating the copyright year should suffice.

Relicensing without the non-advertising clause would be nice but
that's for another patch and needs to be acked by the other authors.
Just adding another license is not going to do that.



More information about the xorg-devel mailing list