[PATCH] os: warn about releasing signals inside signal handler

Peter Hutterer peter.hutterer at who-t.net
Sat Aug 4 00:43:21 PDT 2012


On Wed, Aug 01, 2012 at 12:06:30PM +1000, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  os/utils.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/os/utils.c b/os/utils.c
> index d902523..cb37162 100644
> --- a/os/utils.c
> +++ b/os/utils.c
> @@ -1234,6 +1234,8 @@ OsReleaseSIGIO(void)
>  void
>  OsReleaseSignals(void)
>  {
> +    BUG_WARN(inSignalContext);
> +
>  #ifdef SIG_BLOCK
>      if (--BlockedSignalCount == 0) {
>          sigprocmask(SIG_SETMASK, &PreviousSignalMask, 0);
> -- 
> 1.7.10.4

Patch withdrawn. It helped me find the real bug, but it can't go in as-is
since it triggers warnings on any timer code. Real fix for the issue is
here:
http://patchwork.freedesktop.org/patch/11548/

Cheers,
   Peter



More information about the xorg-devel mailing list