Re: 答复: [PATCH 4/4]new driver initial patch 4

Michal Suchanek hramrach at
Wed Aug 1 03:14:11 PDT 2012


thanks for working on this.

Some of the earlier patches look passable
but this patch is clearly bogus.

Also no need to CC me on these series, I am not a X developer nor do I
have any SMI hardware on which I would test these patches.

On 1 August 2012 11:48, Aaron.Chen  陈俊杰 <aaron.chen at> wrote:
> Hi,
> From dc32739681307e544554642222c51611bafa6274 Mon Sep 17 00:00:00 2001
> From: Aaron Chen <aaron.chen at>
> Date: Wed, 1 Aug 2012 17:15:19 +0800
> Subject: [PATCH 4/4] new driver initial patch 4

This is exactly how patch summary should not look like.
It says nothing about the function of the patch.

> Delete useless files.

This is totally bogus. No files are deleted.

Also this is a lone automake patch which is obviously wrong. I do not
understand automake but some of the changes seem bogus and useless -
dequoting previously [quoted] strings, lowering Xorg macro version
requirement, ..

Besides there are changes that tell automake about new files. These
should be included in patch that introduces the files or in the
following patch that integrates the added files into the new driver so
that after every patch the driver is buildable.

> Signed-off-by: Aaron Chen <aaron.chen at>
> ---
>  |   11 +++----
> |   94 ++++++++++++++++++++++++++++++++--------------------------
>  2 files changed, 57 insertions(+), 48 deletions(-)
> Aaron

More information about the xorg-devel mailing list