[PATCH:xf86-input-keyboard] Set XI_PROP_DEVICE_NODE property to string from "Device" option

Peter Hutterer peter.hutterer at who-t.net
Mon Apr 30 19:45:02 PDT 2012


On Mon, Apr 30, 2012 at 07:34:20PM -0700, Alan Coopersmith wrote:
> On 04/30/12 06:53 PM, Peter Hutterer wrote:
> > does this actually work? Looks like in the default configuration (without
> > Option "Device" set) this will always be null. don't care much about Linux
> > here since we don't really use it anymore but you may want to add a
> > xf86ReplaceStrOption() in src/sun_kbd.c:OpenKeyboard to force the option to
> > whatever you ended up using.
> 
> It worked on Solaris 11 in my testing, but I was only testing with input devices
> coming from HAL, which was passing through the HAL-provided device path,
> and didn't think to test the non-HAL case.   You are correct that case doesn't
> set the property, and that adding xf86ReplaceStrOption to OpenKeyboard replaced
> it.
> 
> I'll handle that in a separate patch, so it's more obvious what the BSD & Hurd
> folks need to do if they care about setting it.

Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net> for the original
patch then.

Cheers,
  Peter


More information about the xorg-devel mailing list